celogeek/go-comic-converter
1
0
Fork 0
mirror of https://github.com/celogeek/go-comic-converter.git synced 2025-05-25 08:12:36 +02:00
Code Issues Packages Projects Releases Wiki Activity

improve buffer usage

Browse Source
This commit is contained in:
Celogeek 2023-04-25 11:15:23 +02:00
parent 9da0887334
commit dbec9b81e8
Signed by: celogeek
SSH Key Fingerprint: SHA256:njNJLzoLQdbV9PC6ehcruRb0QnEgxABoCYZ+0+aUIYc
2 changed files with 6 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
internal/converter/converter.go
View File

@ -30,8 +30,8 @@ func New() *Converter {
order: make([]Order, 0), order: make([]Order, 0),
} }
cmdOutput := &strings.Builder{} var cmdOutput strings.Builder
cmd.SetOutput(cmdOutput) cmd.SetOutput(&cmdOutput)
cmd.Usage = func() { cmd.Usage = func() {
fmt.Fprintf(os.Stderr, "Usage of %s:\n", filepath.Base(os.Args[0])) fmt.Fprintf(os.Stderr, "Usage of %s:\n", filepath.Base(os.Args[0]))
for _, o := range conv.order { for _, o := range conv.order {

6
internal/epub/image_processing/epub_image_processing_loader.go
View File

@ -28,16 +28,18 @@ type Options struct {
} }
func (o *Options) mustExtractImage(imageOpener func() (io.ReadCloser, error)) *bytes.Buffer { func (o *Options) mustExtractImage(imageOpener func() (io.ReadCloser, error)) *bytes.Buffer {
var b bytes.Buffer
if o.Dry { if o.Dry {
return &bytes.Buffer{} return &b
} }
f, err := imageOpener() f, err := imageOpener()
if err != nil { if err != nil {
fmt.Fprintln(os.Stderr, err) fmt.Fprintln(os.Stderr, err)
os.Exit(1) os.Exit(1)
} }
defer f.Close() defer f.Close()
var b bytes.Buffer
_, err = io.Copy(&b, f) _, err = io.Copy(&b, f)
if err != nil { if err != nil {
fmt.Fprintln(os.Stderr, err) fmt.Fprintln(os.Stderr, err)